Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing AttributeError when kernel cleanup occurs before the kernel is created. #61

Merged
merged 1 commit into from
May 19, 2020
Merged

Fixing AttributeError when kernel cleanup occurs before the kernel is created. #61

merged 1 commit into from
May 19, 2020

Conversation

golf-player
Copy link
Contributor

No description provided.

@golf-player golf-player mentioned this pull request May 19, 2020
Closed
@golf-player
Copy link
Contributor Author

I put the check in execute since it's only the first one causing problems. In other cases where kernel cleanup is called and fails because kernel_manager is not defined, it's probably best to fail since something is very wrong

@davidbrochart
Copy link
Member

LGTM.

@davidbrochart davidbrochart merged commit 2d862a9 into jupyter:master May 19, 2020
@davidbrochart
Copy link
Member

Thanks!

@golf-player
Copy link
Contributor Author

golf-player commented May 19, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@golf-player @davidbrochart